Skip to content

Conversation

@samford
Copy link
Member

@samford samford commented Nov 2, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

nomachine-enterprise-client is autobumped but it hasn't been updated since version 8.16.1_2 because the livecheck block is broken. The download page requires a cookie or the server will redirect to a login page instead, which may be what's happening with the existing check. Unlike nomachine, I haven't yet found a fix for this yet.

In the interim time, this updates the cask to the newest version after manually checking the upstream download page.


I've created this as a draft for now and will try to dig more into the livecheck block issue tomorrow (anyone feel free to beat me to it).

@samford samford added the livecheck Issues or PRs related to livecheck label Nov 2, 2025
@p-linnane p-linnane added the awaiting maintainer feedback Issue needs response from a maintainer. label Nov 10, 2025
@p-linnane p-linnane force-pushed the nomachine-enterprise-client-9.2.18_1 branch from 1132c80 to 2850355 Compare November 22, 2025 05:34
`nomachine-enterprise-client` is autobumped but it hasn't been updated
since version 8.16.1_2 because the `livecheck` block is broken. The
download page requires a cookie or the server will redirect to a login
page instead, which may be what's happening with the existing check.
The app checks for updates but I wasn't able to identify what URL it's
checking, so I couldn't find an alternative source of version
information. However, the versions seem to generally align with
`nomachine` versions/updates, so setting the `livecheck` block to
use the `nomachine` check is better than nothing (i.e., it may be fine
a majority of the time).
@samford samford force-pushed the nomachine-enterprise-client-9.2.18_1 branch from 2850355 to 9780e9e Compare December 8, 2025 22:36
@samford
Copy link
Member Author

samford commented Dec 8, 2025

Finally coming back to this and I wasn't able to capture any network requests from the app, so I couldn't identify what URL the in-app updater checks. However, the versions seem to generally align with nomachine versions/updates, so setting the livecheck block to use the nomachine check is better than nothing. I've update the commit to use cask "nomachine" in the livecheck block for the time being, as it seems like that should be fine a majority of the time (based on previous update PRs).

@samford samford marked this pull request as ready for review December 8, 2025 22:38
@samford samford removed the awaiting maintainer feedback Issue needs response from a maintainer. label Dec 8, 2025
@p-linnane p-linnane added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 0db09c6 Dec 9, 2025
23 checks passed
@p-linnane p-linnane deleted the nomachine-enterprise-client-9.2.18_1 branch December 9, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

livecheck Issues or PRs related to livecheck

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants