styled the new contests page #183
Conversation
|
@NikhilSharmaWe Thanks for working on this! It would be better if you attach some screenshots, in the PR itself. |
Signior-X
left a comment
Signior-X
left a comment
There was a problem hiding this comment.
Good that you tried!
And you know how to write, just a better color scheme and look will be highly appreciated.
Looking for the changes soon!
| @@ -1,3 +1,4 @@ | |||
| import "./contests.css". | |||
There was a problem hiding this comment.
You should not import any css in the models
This is just the mongodb model.
Also I think there no any contests.css so remove this from here.
| } | ||
| </style> |
There was a problem hiding this comment.
The styles you added here doesn't look good or match with the Theme.
You could have tried to add colors in the whole inner box and giving a brown background at the heading makes it ugly.
There was a problem hiding this comment.
You can try to make it center and instead of using different colors, try using the same color scheme with different contrast.
Yellow somewhere blue somewhere brown doesn't look good.
I hope you get it.
2 participants
What's this PR do? (related issue if exists)
it styles the new contests page
Any context you want to provide on the implementation?
Screenshots? (necessary if an UI/UX change)