Merge pull request #52 from atapatel/main

Fix union query issue

Author: aarondfrancis

src/FastPaginate.php

@@ -43,10 +43,10 @@ protected function paginate(string $paginationMethod, Closure $paginatorOutput)
         ) {
             /** @var \Illuminate\Database\Query\Builder $this */
             $base = $this->getQuery();
-            // Havings and groups don't work well with this paradigm, because we are
-            // counting on each row of the inner query to return a primary key
+            // Havings, groups, and unions don't work well with this paradigm, because
+            // we are counting on each row of the inner query to return a primary key
             // that we can use. When grouping, that's not always the case.
-            if (filled($base->havings) || filled($base->groups)) {
+            if (filled($base->havings) || filled($base->groups) || filled($base->unions)) {
                 return $this->{$paginationMethod}($perPage, $columns, $pageName, $page);
             }
 
@@ -99,6 +99,7 @@ protected function paginate(string $paginationMethod, Closure $paginatorOutput)
     }
 
     /**
+     * @param $builder
      * @return array
      *
      * @throws QueryIncompatibleWithFastPagination

tests/Integration/BuilderTest.php

@@ -408,4 +408,19 @@ public function with_sum_has_the_correct_number_of_parameters()
 
         $this->assertEquals(get_class($fast), get_class($regular));
     }
+
+    public function test_for_union_query()
+    {
+        $queries = $this->withQueriesLogged(function () use (&$results) {
+            $results = User::where('id', '<', 10)
+                ->unionAll(User::where('id', '>', 10))
+                ->fastPaginate(2);
+        });
+
+        $this->assertEquals($queries[0]['query'],
+            'select count(*) as aggregate from ((select * from `users` where `id` < ?) union all (select * from `users` where `id` > ?)) as `temp_table`');
+
+        $this->assertEquals($queries[1]['query'],
+            '(select * from `users` where `id` < ?) union all (select * from `users` where `id` > ?) limit 2 offset 0');
+    }
 }