Add djade linter for Django templates (Fixes #2372) #2382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahboyce
reviewed
Dec 8, 2025
aNsHuL5217
force-pushed
the
add-djade-linter
branch
from
6f24eca to
cb91ead
Compare
aNsHuL5217
force-pushed
the
add-djade-linter
branch
from
cb91ead to
892f574
Compare
sarahboyce
reviewed
Dec 8, 2025
Contributor
sarahboyce
left a comment
sarahboyce
left a comment
There was a problem hiding this comment.
Thank you! A couple of minor nitpicks
| rev: 1.6.0 | ||
| hooks: | ||
| - id: djade | ||
| args: [--target-version, "4.2"] |
Contributor
There was a problem hiding this comment.
Suggested change
| args: [--target-version, "4.2"] | |
| args: [--target-version, "5.2"] |
This should match our Django version
| djangoproject/cache | ||
| djangoproject/static/css/*.map | ||
| djangoproject/static/css/*.css | ||
| .DS_Store |
Contributor
There was a problem hiding this comment.
Suggested change
| .DS_Store |
| {% endfor %} | ||
| {##} | ||
| {% endblock %} | ||
| {# #} |
Contributor
There was a problem hiding this comment.
Suggested change
| {# #} |
Empty comment is odd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the
djadelinter to the project's pre-commit configuration and applies formatting fixes to existing Django templates. This ensures consistent code style (e.g., standardizing whitespace in{{ variables }}) across the codebase.Rationale
As discussed in #2372,
djadewas selected over alternatives likedjLintbecausedjadeis actively maintained and specifically targets Django template formatting. This aligns with the project's goal of using stable, long-term tools.Changes
adamchainz/djade-pre-commit(v1.6.0) to.pre-commit-config.yaml..htmltemplates.Verification
pre-commit run djade --all-fileslocally (passed formatting checks).