proposal: cmd/vet: include testinggoroutine analyzer in 'go test' suite

[seankhliao]

Go version

go version go1.26-devel_3f94f3d4b2 2025-11-28 15:26:25 -0800 linux/amd64

Output of go env in your module/workspace:

AR='ar'
CC='gcc'
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_ENABLED='1'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
CXX='g++'
GCCGO='gccgo'
GO111MODULE=''
GOAMD64='v1'
GOARCH='amd64'
GOAUTH='netrc'
GOBIN=''
GOCACHE='/home/user/.cache/go-build'
GOCACHEPROG=''
GODEBUG=''
GOENV=''
GOEXE=''
GOEXPERIMENT=''
GOFIPS140='off'
GOFLAGS=''
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build366711227=/tmp/go-build -gno-record-gcc-switches'
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMOD='/home/user/tmp/testrepo1338/go.mod'
GOMODCACHE='/home/user/.data/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/user/.data/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/user/sdk/gotip'
GOSUMDB='sum.golang.org'
GOTELEMETRY='on'
GOTELEMETRYDIR='/home/user/.config/go/telemetry'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/user/sdk/gotip/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.26-devel_3f94f3d4b2 2025-11-28 15:26:25 -0800'
GOWORK=''
PKG_CONFIG='pkg-config'

What did you do?

try to run the reproducer in #15758

package main

import (
	"testing"
	"time"
)

func TestFoo(t *testing.T) {
	go func() {
		t.Fatal("fatal") // Called from outside the Test function
	}()
	time.Sleep(1 * time.Second)
}

What did you see happen?

$ go test
--- FAIL: TestFoo (1.00s)
    main_test.go:10: fatal
FAIL
exit status 1
FAIL	go.seankhliao.com/testrepo1338	1.003s

$ go vet
main_test.go:10:3: call to (*testing.T).Fatal from a non-test goroutine

What did you expect to see?

The vet check to be enabled by default:

$ go test -vet=all
# go.seankhliao.com/testrepo1338
# [go.seankhliao.com/testrepo1338]
./main_test.go:10:3: call to (*testing.T).Fatal from a non-test goroutine
FAIL	go.seankhliao.com/testrepo1338 [build failed]

---

The analysis is golang.org/x/tools/go/analysis/passes/testinggoroutine, I don't know of any false positives that would prevent its inclusion by default.

[seankhliao]

cc @adonovan maybe?

[gabyhelp]

Related Issues

• cmd/vet: check for concurrent use of T.FatalX and T.SkipX #15674
• x/tools/go/analysis/passes/testinggoroutine: do not ignore calls in goroutines (false negative) #63849
• testing: complain loudly during concurrent use of T.FatalX and T.SkipX #15758
• x/tools/go/analysis/passes/testinggoroutine: ignore subtests in goroutines (false positive) #63799 (closed)
• cmd/go: list default vet flags in go test -help #26786 (closed)
• cmd/go: run vet automatically during 'go test' #18084 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[adonovan]

(This needs a proposal, so it's not going to happen for 1.26. Perhaps we should batch up the proposals to "promote" a bunch of analyzers, from gopls-only to go vet, and from go vet to go test.)

I ran it over 29K modules from the module mirror corpus (which is now much faster thanks to the work of my colleagues) and got 1937 diagnostics in 340 (1% of) modules. 50 diagnostic are selected at random below. While all of them correctly indicate a call to t.Fatal from a non-Test goroutine (breaking the letter of the law), only some of them are concurrent with the normal return of the Test function, which I think is the spirit of the law since t.Fatal itself was made thread-safe.

cc: @neild

https://go-mod-viewer.appspot.com/github.com/armon/go-proxyproto@v0.1.0/protocol_test.go#L311: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/openfaas/faas-provider@v0.25.9/logs/handler_test.go#L80: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/go.dedis.ch/onet/v4@v4.0.0-pre1/node_test.go#L379: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/df-mc/goleveldb@v1.1.9/leveldb/db_test.go#L2381: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/Xhofe/rateg@v0.1.0/fn_limiter_test.go#L90: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/gitlab.com/SiaPrime/SiaPrime@v1.4.1/modules/host/contractmanager/sectorupdate_test.go#L834: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/coyove/common@v0.0.0-20240403014525-f70e643f9de8/clock/clock_test.go#L25: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/iamduo/workq@v0.0.0-20170927090418-fc15ddb28967/int/job/controller_run_test.go#L64: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/praetorian-inc/fingerprintx@v1.1.15/third_party/cryptolib/ssh/session_test.go#L40: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/couchbase/moss@v0.3.0/store_test.go#L2333: call to (*testing.T).Fatalf from a non-test goroutine (load calls (*testing.T).Fatalf)
https://go-mod-viewer.appspot.com/github.com/erikdubbelboer/fasthttp@v1.1.0/server_test.go#L2638: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/dubbogo/go-zookeeper@v1.0.4/zk/lock_test.go#L43: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/praetorian-inc/fingerprintx@v1.1.15/third_party/cryptolib/ssh/mux_test.go#L402: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/z-division/go-zookeeper@v1.0.0/zk/lock_test.go#L39: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/iamduo/workq@v0.0.0-20170927090418-fc15ddb28967/int/job/wqueue_test.go#L300: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/admpub/tail@v1.1.1/tail_test.go#L141: call to (github.com/admpub/tail.TailTest).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/VictoriaMetrics/fasthttp@v1.2.0/fasthttputil/inmemory_listener_test.go#L62: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/btccom/go-micro/v2@v2.9.3/transport/memory/memory_test.go#L38: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/git.cs.nctu.edu.tw/calee/sctp@v1.1.0/sctp_test.go#L190: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/micro/go-micro/v2@v2.9.1/transport/http_transport_test.go#L205: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/futurehomeno/fimpgo@v1.14.1/fimptype/primefimp/api-client_test.go#L194: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/livepeer/m3u8@v0.11.1/writer_test.go#L556: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/gitee.com/liuxuezhan/go-micro-v1.18.0@v1.0.0/tunnel/tunnel_test.go#L244: call to (*testing.T).Fatal from a non-test goroutine (testSend calls (*testing.T).Fatal)
https://go-mod-viewer.appspot.com/github.com/keimoon/gore@v0.0.0-20160317032603-1ac8b93b5fdb/command_test.go#L228: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/VictoriaMetrics/fasthttp@v1.2.0/reuseport/reuseport_test.go#L69: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/gopkg.in/fsnotify.v1@v1.4.7/integration_test.go#L666: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/soheilhy/cmux@v0.1.5/cmux_test.go#L338: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/rulego/rulego@v0.34.4/endpoint/rest/rest_test.go#L126: call to (*testing.T).Fatal from a non-test goroutine (startServer calls (*testing.T).Fatal)
https://go-mod-viewer.appspot.com/github.com/square/p2@v0.0.0-20200114213136-8223eb1817fb/pkg/health/checker/checker_test.go#L65: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/praetorian-inc/fingerprintx@v1.1.15/third_party/cryptolib/ssh/mux_test.go#L325: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/rulego/rulego@v0.34.4/endpoint/websocket/websocket_test.go#L119: call to (*testing.T).Fatal from a non-test goroutine (startServer calls (*testing.T).Fatal)
https://go-mod-viewer.appspot.com/github.com/tickoalcantara12/micro/v3@v3.0.0-20221007104245-9d75b9bcbab9/service/network/transport/http/http_test.go#L107: call to (*testing.B).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/go-akka/configuration@v0.0.0-20200606091224-a002c0330665/configuration_test.go#L42: call to (*testing.T).Fatalf from a non-test goroutine (fn calls (*testing.T).Fatalf)
https://go-mod-viewer.appspot.com/gitlab.com/SiaPrime/SiaPrime@v1.4.1/siatest/renter/renter_vlong_test.go#L175: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/soheilhy/cmux@v0.1.5/cmux_test.go#L445: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/square/p2@v0.0.0-20200114213136-8223eb1817fb/pkg/grpc/daemonsetstore/daemon_set_store_test.go#L215: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/go-akka/configuration@v0.0.0-20200606091224-a002c0330665/configuration_test.go#L41: call to (*testing.T).Fatalf from a non-test goroutine (fn calls (*testing.T).Fatalf)
https://go-mod-viewer.appspot.com/layeh.com/gopher-luar@v1.0.11/chan_test.go#L18: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/ActiveState/tail@v1.0.0/tail_test.go#L129: call to (github.com/ActiveState/tail.TailTest).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/styfstr/confluent-kafka-go/v2@v2.0.5/kafka/stats_event_test.go#L73: call to (*testing.T).Fatalf from a non-test goroutine (handleStatsEvent calls (*testing.T).Fatalf)
https://go-mod-viewer.appspot.com/github.com/cyrus-and/gdb@v0.0.0-20230321224603-9424cb2f2a86/interrupt_test.go#L33: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/valyala/gorpc@v0.0.0-20160519171614-908281bef774/bench_test.go#L50: call to (*testing.B).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/annwntech/go-micro/v2@v2.9.5/transport/http/http_test.go#L93: call to (*testing.B).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/go-micro.dev/v5@v5.12.0/events/natsjs/nats_test.go#L40: call to (*testing.T).Fatalf from a non-test goroutine (natsServer calls (*testing.T).Fatalf)
https://go-mod-viewer.appspot.com/github.com/blevesearch/goleveldb@v1.1.0/leveldb/db_test.go#L2502: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/btcsuite/golangcrypto@v0.0.0-20150304025918-53f62d9b43e8/ssh/benchmark_test.go#L92: call to (*testing.B).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/kdcer/go-micro@v0.0.0-20200917085549-f03dd2ec5b56/transport/http/http_test.go#L93: call to (*testing.B).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/gopkg.in/fsnotify.v1@v1.4.7/integration_test.go#L759: call to (*testing.T).Fatalf from a non-test goroutine
https://go-mod-viewer.appspot.com/gitlab.com/SiaPrime/SiaPrime@v1.4.1/siatest/renter/renter_vlong_test.go#L265: call to (*testing.T).Fatal from a non-test goroutine
https://go-mod-viewer.appspot.com/github.com/annwntech/go-micro/v2@v2.9.5/tunnel/tunnel_test.go#L287: call to (*testing.T).Fatal from a non-test goroutine (testSend calls (*testing.T).Fatal)