Skip to content

Conversation

@owlpharoah
Copy link
Contributor

Problem

Accounts tagged spam tend to subscribe even after leading to trivial subscription counts across the site

Solution

The solution is to remove all types of subscriptions off of accounts when they are marked spam from the admin menu.

Testing

tested it locally by marking an account as spammer and then checking change in subscription.

Copy link
Member

@mwiencek mwiencek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. This is something that makes sense, but we need to be careful about immediately purging data like this, because people can be marked as spammers accidentally or based on a misunderstanding. In a related ticket (I can't find it right now, because Jira isn't working) we discussed adding a cron job that runs monthly and moves spammer data to another schema. That's the direction I think we should go in, so I wouldn't accept this patch in its current form.

@owlpharoah
Copy link
Contributor Author

hi! thanks for letting me know. I'm assuming the ticket youre talking about is MBS-14096. Regarding that ticket, is it necessary we have a whole another table for spammers or instead just run the cron job to check when last updated on the same table and then make a deletion.

@owlpharoah owlpharoah closed this Dec 8, 2025
@owlpharoah owlpharoah deleted the mbs-14087 branch December 8, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants