Fail to initialize onnxruntime with 1.21.0 on windows

[HerrDerb]

After the update to com.microsoft.onnxruntime:onnxruntime:1.21.0 I do get an error when trying to load the runtime in java (21). Colleagues with a mac seems not to experience this issue.

java.lang.UnsatisfiedLinkError: ~\AppData\Local\Temp\onnxruntime-java3314415972495013183\onnxruntime.dll: A dynamic link library (DLL) initialization routine failed
	at java.base/jdk.internal.loader.NativeLibraries.load(Native Method)
	at java.base/jdk.internal.loader.NativeLibraries$NativeLibraryImpl.open(NativeLibraries.java:331)
	at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:197)
	at java.base/jdk.internal.loader.NativeLibraries.loadLibrary(NativeLibraries.java:139)
	at java.base/java.lang.ClassLoader.loadLibrary(ClassLoader.java:2418)
	at java.base/java.lang.Runtime.load0(Runtime.java:852)
	at java.base/java.lang.System.load(System.java:2025)
	at ai.onnxruntime.OnnxRuntime.load(OnnxRuntime.java:387)
	at ai.onnxruntime.OnnxRuntime.init(OnnxRuntime.java:166)
	at ai.onnxruntime.OrtEnvironment.<clinit>(OrtEnvironment.java:34)
        ....

while I do have the latest VC++ redistributables

maybe related to #23957?

[Craigacp]

It's broken for me too, it's failing on GitHub Actions' default Windows runner - https://github.com/oracle/tribuo/actions/runs/13768367698/job/38500483425?pr=396. Unfortunately I don't know what Windows build system changes happened for this release, but something is different.

[snnn]

Add this powershell script to your action:

Get-ChildItem -Path $env:AGENT_TOOLSDIRECTORY -File -Include msvcp*.dll,concrt*.dll,vccorlib*.dll,vcruntime*.dll -Recurse | Remove-Item -Force -Verbose

[snnn]

Please see this table: https://learn.microsoft.com/en-us/lifecycle/faq/visual-c-faq#what-are-the-support-dates-for-visual-c---redistributable--msvc-runtime-libraries--and-msvc-toolset-versions-2015--2017--2019--2022--and-later-

Let's say, we are distributing a program which contains multiple components, the MSVC Redistributable & runtime libraries' version must be at least as new as the latest toolset used by any app component according to the table above. For example, the 1.20.0 version onnxruntime.dll was built by MSVC V143 - 14.38 (see the first column of the table), so when it is used by a java application, the MSVC runtime's version must be >=14.38.33142.0 (see the second column of the table). Then, in this release we upgrade the toolchain to 14.40, so the runtime requirement was also increased.

[rebsp]

But OP clearly has a runtime >= 14.40 installed (14.42.34438.0) so why is it still crashing?

[HerrDerb]

So this update breaks the usage for windows and default jvm installation? Or do I missunderstand?

[snnn]

For Oracle JVMs, yes. Because it comes with MSVC runtime 14.36. Even there was no crash issues with the previous ORT release(1.20), it was not expected to work(it had undefined behavior).

[HerrDerb]

Thanks for the clarification ,yeah this is actually really weird :) . I tested and found that only removing or renaming bin/msvcp140.dll resolves the issue, as the system-installed DLL seems then to be used.

[HerrDerb]

Well or actually just update to the latest jvm :)

[matthieu-labas]

Even there was no crash issues with the previous ORT release(1.20), it was not expected to work(it had undefined behavior)

How do you know which MSVC runtime version is used for a given JDK? And which (lower) version is expected to work without UB?

[sdbds]

So has this issue been resolved in 1.22, or do you have to manually update your JVM?

[sdbds]

The easiest way is to update to a JVM which has been compiled against newer VC libs.

Thanks for the clarification, I still removed the old version that came with VC, and that resolved the issue. However, it's difficult to ask users to do the same...

[Craigacp]

Different builds of OpenJDK are compiled against different VC redists. My understanding is that the current OpenJDK builds provided by Oracle, and the Oracle Java SE builds are still using an older version of the VC redist, though there are other suppliers which are using a newer version (for all their JDK builds, e.g. 8, 11, 17).

[matthieu-labas]

@Craigacp would you know how to get which VC redist version a specific OpenJDK is compiled against? I check e.g. OpenJDK 24 release notes but I see no mention of any VC runtime...

[Craigacp]

I don't know if there's an official way to tell, but if you download it you can look at the version number in the vcredist dll.

[matthieu-labas]

Thanks @Craigacp, I indeed see a bin\vcruntime140.dll in the JDK directory.

[dliubarskyi]

Does anyone know which JDK distribution works with onnxruntime 1.22.0?

[matthieu-labas]

Does anyone know which JDK distribution works with onnxruntime 1.22.0?

JDK 24 is not working, I think we'll have to wait, unless you want to compile your own...

[Craigacp]

Oracle's JDKs are not currently compiled with the latest VC, but other JDK providers have their own build toolchain and some of those are using the latest VC.

[chenkelmann]

I got it working with the Microsoft OpenJDK 21.0.8 Build:
https://learn.microsoft.com/en-us/java/openjdk/download
https://aka.ms/download-jdk/microsoft-jdk-21.0.8-windows-x64.zip

[lizhen789]

还真是这样，那用起来就有些麻烦了