Update "isSafari" detection to include iOS and macOS #3215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac, we’ve run into an issue (#3214) where the page jumps back to the top after adding a column or row using the "+" button in a table.
This seems to be a common WebKit issue—the
clickevent causes the editable area to lose focus, which in turn makes the editor lose its selection.We noticed there’s already a fix for Safari that caches the selection and restores it when the editor regains focus after
onBlur.Since iOS and macOS both use WebKit and should behave the same way as Safari, this PR updates the scope of
isSafarienvironment to include both iOS and macOS so they can leverage the same Safari-specific fixes.