feat: Add support for exporting telemetry API 'platform.*' log events #2058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herin049
commented
Dec 8, 2025
|
|
||
| address, err := listener.Start() | ||
| require.NoError(t, err) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The use of t.Cleanup() appeared to trigger a race condition using the race detector with zap.Logger switching to using defer appears to fix the issue.
herin049
force-pushed
the
fix/report-platform-logs
branch
from
296c7f2 to
0c0e36a
Compare
herin049
commented
Dec 8, 2025
| Port int `mapstructure:"port"` | ||
| Types []string `mapstructure:"types"` | ||
| LogReport bool `mapstructure:"log_report"` | ||
| LogReport *bool `mapstructure:"log_report"` |
Contributor
Author
There was a problem hiding this comment.
Switch to pointer to allow default value to be true
herin049
changed the title
herin049
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2054 where
platform.*telemetry API event types (except part ofplatform.report) do not get exported for logging. The implemented solution captures all logs by default, and simplifies the current implementation by reusing the core log record construction logic while reducing code duplication.I have setup a toy lambda function to export logs to Grafana Cloud with the changes in this PR, here are the updated logs:
