-
Notifications
You must be signed in to change notification settings - Fork 58
Prom name function #1051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Prom name function #1051
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1051 +/- ##
======================================
Coverage 79.0% 79.0%
======================================
Files 85 87 +2
Lines 7034 7155 +121
======================================
+ Hits 5558 5657 +99
- Misses 1476 1498 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| "min" => Some("minutes"), | ||
| "s" => Some("seconds"), | ||
| "ms" => Some("milliseconds"), | ||
| "us" => Some("microseconds"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is μs something that could/should be catered for too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied that from the rust SDK - and I think that comes from the go reference implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use UCCM standard, not sure that's emojii-ified yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the Greek letter mu is an emoji 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - I should have mentioned "any non-US character set" - https://ucum.org/ucum <- They explicitly say they only use US-ASCII here.
Interesting, by specification when printing us, you're supposed to use Greek "mu", not u.
Uh oh!
There was an error while loading. Please reload this page.