Skip to content

Conversation

@zeitlinger
Copy link
Member

@zeitlinger zeitlinger commented Dec 3, 2025

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

❌ Patch coverage is 87.28814% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.0%. Comparing base (33083ad) to head (4ec3f0e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_forge/src/extensions/otel.rs 11.7% 15 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #1051    +/-   ##
======================================
  Coverage   79.0%   79.0%            
======================================
  Files         85      87     +2     
  Lines       7034    7155   +121     
======================================
+ Hits        5558    5657    +99     
- Misses      1476    1498    +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

"min" => Some("minutes"),
"s" => Some("seconds"),
"ms" => Some("milliseconds"),
"us" => Some("microseconds"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is μs something that could/should be catered for too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied that from the rust SDK - and I think that comes from the go reference implementation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use UCCM standard, not sure that's emojii-ified yet.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the Greek letter mu is an emoji 😄

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - I should have mentioned "any non-US character set" - https://ucum.org/ucum <- They explicitly say they only use US-ASCII here.

Interesting, by specification when printing us, you're supposed to use Greek "mu", not u.

@zeitlinger zeitlinger marked this pull request as ready for review December 4, 2025 15:58
@zeitlinger zeitlinger requested a review from a team as a code owner December 4, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants