Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

Closes #850

Scope's are no longer required to have attributes as per the specification

@thompson-tomo thompson-tomo requested a review from a team as a code owner July 21, 2025 01:44
@jsuereth
Copy link
Contributor

I still think, as scope is mostly unused in weaver / semconv so far, it'd be nice to understand the plans for defining scope here, as it relates to V2 syntax where we'll have scope more explicit.

In fact, I'd prefer if we just don't add dependencies on using Scope in weaver for now until we migrate to V2 schema so we can clean up the YAML more easily.

Is there a compelling reason we need to add scope support now? I realize it's a hole in semconv today, but it's been like that for quite some time, I think another few months isn't going to cause significant burdens to semconv.

@thompson-tomo
Copy link
Contributor Author

thompson-tomo commented Jul 22, 2025

Actually I am not adding support for scopes as that is pre-existing functionality. But just removing the requirement of scopes to have attributes to match the spec.

@thompson-tomo thompson-tomo force-pushed the feature/#850_NoAttributeScopes branch from 0303833 to 85809e2 Compare August 20, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope shouldn't require attributes

2 participants