Merge pull request #156 from Krinkle/fix-php84-trigger

Throw `new Error` instead of E_USER_ERROR on PHP 7.0+

Author: ashnazg

PEAR.php

@@ -216,9 +216,13 @@ function _PEAR() {
     public function __call($method, $arguments)
     {
         if (!isset(self::$bivalentMethods[$method])) {
-            trigger_error(
-                'Call to undefined method PEAR::' . $method . '()', E_USER_ERROR
-            );
+           if (PHP_VERSION_ID < 70000) {
+                trigger_error(
+                    'Call to undefined method PEAR::' . $method . '()', E_USER_ERROR
+                );
+            } else {
+                throw new Error('Call to undefined method PEAR::' . $method . '()');
+            }
         }
         return call_user_func_array(
             array(__CLASS__, '_' . $method),
@@ -229,9 +233,13 @@ public function __call($method, $arguments)
     public static function __callStatic($method, $arguments)
     {
         if (!isset(self::$bivalentMethods[$method])) {
-            trigger_error(
-                'Call to undefined method PEAR::' . $method . '()', E_USER_ERROR
-            );
+            if (PHP_VERSION_ID < 70000) {
+                trigger_error(
+                    'Call to undefined method PEAR::' . $method . '()', E_USER_ERROR
+                );
+            } else {
+                throw new Error('Call to undefined method PEAR::' . $method . '()');
+            }
         }
         return call_user_func_array(
             array(__CLASS__, '_' . $method),

PEAR/Frontend/CLI.php

@@ -357,7 +357,11 @@ function userDialog($command, $prompts, $types = array(), $defaults = array(), $
 
     function userConfirm($prompt, $default = 'yes')
     {
-        trigger_error("PEAR_Frontend_CLI::userConfirm not yet converted", E_USER_ERROR);
+        if (PHP_VERSION_ID < 70000) {
+            trigger_error("PEAR_Frontend_CLI::userConfirm not yet converted", E_USER_ERROR);
+        } else {
+            throw new Error('PEAR_Frontend_CLI::userConfirm not yet converted');
+        }
         static $positives = array('y', 'yes', 'on', '1');
         static $negatives = array('n', 'no', 'off', '0');
         print "$this->lp$prompt [$default] : ";