[RFC] Implementation of FR 20298

[robbchar]

Summary

The requested feature is here, it was made a bit ago so I wanted to start a discussion about a potential implementation.

Problem Statement

The discussion was about removing the limit for preset colors for swatches under the color picker:

the limit there being 27 with the first 25 being presets and the last two being custom ones. The idea being that the limit would be removed and then a DS with more than 27 colors could show all of them. But, I was thinking, if the user also wants to be able to choose colors, it is currently implicit that that can happen, every time the user chooses a new color that gets added to the list of swatches so if the limit is removed then the list will get infinitely long OR if the limit stays the presets start falling off, neither of which seems good or in the vein of what was being discussed. Also, it's not easy to tell what the accepted preset swatches are vs which are the custom colors.

Non-goals

No response

Implementation

I propose, when there are presets passed in, that there are two lists of swatches:

Sure, it takes up more space but it's easy to see which is which. The presets would never change and the custom ones can be limited, I suggest just 9 but that could be configurable. In fact, based on the last comment in the issue #20298 (comment), you could have multiple lists of presets. If you do not specify presets that list does not show but a config could be added to not allow custom colors which would hide the color picker...

Prior Art

not certain but this doesn't seem terribly original...

Deliverables

No response

Risks

• If many lists of presets are given that could be visually confusing.

Unresolved Questions

• Can the original ask be expanded to using two lists of swatches?
• Multiple preset lists?
• What should be configurable?
  • can add custom?
  • number of possible custom colors?

Alternatives considered / Abandoned Ideas

No response