fix(runtime-core): ensure correct anchor el for deeper unresolved async components #14182
+121
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughReplaces direct anchor vnode access with a new internal resolver that recursively traverses component wrapper VNodes to locate async component placeholders; adds tests validating Suspense + v-for with multiple async wrappers and list updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested labels
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/runtime-core/src/renderer.ts (1)
2581-2602: Consider adding defensive safeguards for edge cases.The recursive traversal logic correctly handles the wrapper component scenario described in issue #14173. However, consider adding safeguards:
Null check for subTree: Line 2590 accesses
asyncWrapper.subTreewithout verification. If a component exists butsubTreeis undefined (e.g., during initialization or edge cases), this could cause issues.Cycle detection or depth limit: While component trees should be acyclic, a depth limit or cycle detection would prevent potential infinite recursion if the component structure is unexpected.
Apply this diff to add defensive checks:
function resolveAsyncComponentPlaceholder(anchorVnode: VNode) { // anchor vnode is a unresolved async component if (anchorVnode.placeholder) { return anchorVnode.placeholder } // anchor vnode maybe is a wrapper component has single unresolved async component const asyncWrapper = anchorVnode.component if (asyncWrapper) { const subTree = asyncWrapper.subTree + + // guard against missing subTree + if (!subTree) { + return null + } // wrapper that directly contains an unresolved async component if (subTree.placeholder) { return subTree.placeholder } // try to locate deeper nested async component placeholder return resolveAsyncComponentPlaceholder(subTree) } return null }Alternatively, consider adding a depth parameter to prevent excessive recursion:
function resolveAsyncComponentPlaceholder(anchorVnode: VNode, depth: number = 0): HostNode | null { const MAX_DEPTH = 10 // reasonable limit for nested wrappers if (depth > MAX_DEPTH) { if (__DEV__) { warn('Maximum depth exceeded while resolving async component placeholder') } return null } if (anchorVnode.placeholder) { return anchorVnode.placeholder } const asyncWrapper = anchorVnode.component if (asyncWrapper?.subTree) { if (asyncWrapper.subTree.placeholder) { return asyncWrapper.subTree.placeholder } return resolveAsyncComponentPlaceholder(asyncWrapper.subTree, depth + 1) } return null }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/runtime-core/src/renderer.ts(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
packages/runtime-core/src/renderer.ts (1)
packages/runtime-core/src/vnode.ts (1)
VNode(160-257)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test / e2e-test
🔇 Additional comments (1)
packages/runtime-core/src/renderer.ts (1)
1999-1999: LGTM! Correctly handles nested async component placeholders.The fallback chain (
anchorVNode.el || resolveAsyncComponentPlaceholder(anchorVNode)) appropriately addresses the edge case where wrapper components contain unresolved async components. This ensures the correct anchor is found even when there are intermediate wrapper elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #14173
This is a follow-up to this PR #13928.
The following issue examples are just a sufficiently complex case to describe the current issues with
patchKeyedChildren + async component wrapper, this maby a edge case.this pr playground
issue playground
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.