[Gecko Bug 2001615] Fix carry forward to not override flags from conversion. #56561
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug occurs because any flags about missing components, generated during conversion of the colour (e.g. HSL->OKLCH it can produce a powerless hue) within are overridden by the source colour's flags. The change is to make it instead by a disjunction of the source color flag and the flag of the color itself. Differential Revision: https://phabricator.services.mozilla.com/D275400 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2001615 gecko-commit: 158f0879a03b46e52615d5c2ebd748681c1e2245 gecko-reviewers: tlouw, emilio, firefox-style-system-reviewers
wpt-pr-bot
approved these changes
Dec 8, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug occurs because any flags about missing components, generated during conversion of the colour (e.g. HSL->OKLCH it can produce a powerless hue) within are overridden by the source colour's flags.
The change is to make it instead by a disjunction of the source color flag and the flag of the color itself.
Differential Revision: https://phabricator.services.mozilla.com/D275400
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2001615
gecko-commit: 158f0879a03b46e52615d5c2ebd748681c1e2245
gecko-reviewers: tlouw, emilio, firefox-style-system-reviewers