Fix #74: Add $total parameter to fastPaginate() #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
Allow passing a pre-computed total to skip the expensive COUNT(*) query. This is useful for caching the total count on large tables. The $total parameter works the same as Laravel's built-in paginate() method. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
aarondfrancis
force-pushed
the
fix-74
branch
from
b7ebc69 to
4343f26
Compare
Laravel 11+ added a $total parameter to paginate(). Passing this 5th argument to Laravel 10's paginate() causes a TypeError. This wraps the paginate calls to conditionally pass $total only when running on Laravel 11+. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The closure is bound to Eloquent Builder, so it cannot access protected methods on FastPaginate. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The $total parameter was added in Laravel 11, so on Laravel 10 we can't skip the COUNT query. The test now only asserts the query count and custom total on Laravel 11+. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$totalparameter tofastPaginate()to allow skipping the COUNT querypaginate()methodTest plan
total_can_be_passed_to_skip_count_querythat verifies:🤖 Generated with Claude Code