test(worker): Add tests for blocking_timeout behavior in LockManager #600
+227
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drazisil-codecov
commented
Dec 8, 2025
drazisil-codecov
commented
- Introduced tests to verify that blocking_timeout=None causes indefinite blocking, preventing retry logic from functioning correctly.
- Added a test to ensure that a valid blocking_timeout enables retry logic by raising LockError.
- Updated BundleAnalysisProcessorTask tests to confirm that the default blocking_timeout is used, preventing indefinite blocking.
- Adjusted assertions to reflect changes in retry logic and blocking_timeout handling.
- Introduced tests to verify that blocking_timeout=None causes indefinite blocking, preventing retry logic from functioning correctly. - Added a test to ensure that a valid blocking_timeout enables retry logic by raising LockError. - Updated BundleAnalysisProcessorTask tests to confirm that the default blocking_timeout is used, preventing indefinite blocking. - Adjusted assertions to reflect changes in retry logic and blocking_timeout handling.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
=======================================
Coverage 93.87% 93.87%
=======================================
Files 1284 1284
Lines 46667 46667
Branches 1522 1522
=======================================
Hits 43809 43809
Misses 2548 2548
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.