fix: Prevent unnecessary retries when checking repository existence b… #1478
+137
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y updating GetNonSuccessAsync to retry only on transient 5xx errors, skip deterministic statuses (200/404/301/4xx), add full test coverage, and ensure DoesRepoExist makes a single API call for expected responses. (github#1447)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where repository existence checks would retry unnecessarily on deterministic HTTP responses (200/404/301/4xx), causing delays during migrations. The fix updates GetNonSuccessAsync to use a selective retry strategy that only retries on transient server errors (5xx status codes) rather than retrying on all exceptions.
Key Changes
- Modified
GetNonSuccessAsyncinGithubClient.csto useHttpRetrywith a predicate that filters for 5xx errors only - Added comprehensive test coverage for expected status codes (404), unexpected success (200), server errors with retry (5xx), and redirect status (301)
- Updated release notes to describe the fix in user-friendly terms
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Octoshift/Services/GithubClient.cs | Replaced generic retry logic with selective HTTP retry that only retries on 5xx status codes, ensuring deterministic responses (200/404/301/4xx) return immediately |
| src/OctoshiftCLI.Tests/Octoshift/Services/GithubClientTests.cs | Added four new test cases covering expected status, unexpected success, server error retry behavior, and redirect handling; replaced old retry test with comprehensive coverage |
| RELEASENOTES.md | Added user-friendly description of the fix explaining improved behavior for repository existence checks |
Unit Test Results 1 files 1 suites 10m 24s ⏱️ Results for commit 995f5cb. ♻️ This comment has been updated with latest results. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…y updating GetNonSuccessAsync to retry only on transient 5xx errors, skip deterministic statuses (200/404/301/4xx), add full test coverage, and ensure DoesRepoExist makes a single API call for expected responses. (#1447)
ThirdPartyNotices.txt(if applicable)