Initialize external chat sessions as 'completed' so that they can be disposed #282036
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #282035 by ensuring that external chat sessions can be properly disposed. The fix marks response messages from external chat session history as complete by calling response.complete() immediately after processing each response's parts.
- Adds a single line to mark historical responses as complete, enabling proper disposal of external chat sessions
| model.acceptResponseProgress(lastRequest, part); | ||
| } | ||
|
|
||
| lastRequest.response?.complete(); |
There was a problem hiding this comment.
The fix to mark external chat session responses as complete should be covered by a test case. Consider adding a test in chatService.test.ts that:
- Creates an external chat session with history containing request/response pairs
- Calls
loadSessionForResourcewith that session - Verifies that all responses from history have
isCompleteset to true - Confirms the session can be properly disposed
This would prevent regression of issue #282035.
Tyriar
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#282035 in main