Skip to content

Conversation

@atulgpt17
Copy link
Contributor

@atulgpt17 atulgpt17 commented Dec 5, 2025

Fix the issues which were getting ignored as we were running the detekt w/o type resolution
Type resolution: https://detekt.dev/docs/gettingstarted/type-resolution/

Fixes #1460

@atulgpt17 atulgpt17 requested a review from a team as a code owner December 5, 2025 17:03
active: false
UnusedImports:
active: true
VarCouldBeVal:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was already enabled, I add this explicitly to add the ignoreAnnotated

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any examples of this? We could leave this out until needed?

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.60%. Comparing base (d6af535) to head (bc59dac).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...ibrary/httpurlconnection/HttpUrlInstrumentation.kt 0.00% 4 Missing ⚠️
...id/internal/initialization/InitializationEvents.kt 0.00% 0 Missing and 1 partial ⚠️
...id/instrumentation/AndroidInstrumentationLoader.kt 66.66% 1 Missing ⚠️
...tion/slowrendering/SlowRenderingInstrumentation.kt 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1463      +/-   ##
==========================================
- Coverage   63.70%   63.60%   -0.10%     
==========================================
  Files         159      159              
  Lines        3149     3149              
  Branches      325      327       +2     
==========================================
- Hits         2006     2003       -3     
- Misses       1045     1046       +1     
- Partials       98      100       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah thanks this is great and really shows how detekt helps us to identify potential problems/improvements through static analysis.

The change to the commandline is a bit annoying, because it surfaces the detekt behavior so much. I wish there was a way to do that in config or with some gradle magic, but we could pick that up as a following item.

@breedx-splk breedx-splk merged commit 166e9fc into open-telemetry:main Dec 8, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

We should run detekt with type resolution currently we don't run

2 participants