fix(@desktop/settings): Crash on settings: QQmlComponent: Cannot crea… #19497
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khushboo-dev-cpp
requested review from
dlipicar and
saledjenic
and removed request for
a team
Member
Jenkins BuildsClick to see older builds (24)
|
saledjenic
approved these changes
Dec 5, 2025
…te a component in an invalid context fixes #18888
Khushboo-dev-cpp
force-pushed
the
fix/18888
branch
from
b991403 to
456626a
Compare
jrainville
approved these changes
Dec 5, 2025
Contributor
|
The android build here is crashing at startup. |
caybro
approved these changes
Dec 8, 2025
Member
|
@Khushboo-dev-cpp it fails to build on Windows, and I think it's the QmlToolKit change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…te a component in an invalid context
fixes #18888
QmlToolKit PR -> status-im/QtModelsToolkit#7
What does the PR do
Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
How to test
Risk